Safer Nicotine Wiki talk:Twinkle

From Safer nicotine wiki
Jump to navigation Jump to search


Hello everyone, I'm from viwiki. Yesterday, I made a script which enables Twinkle on mobile view (Minerva skin). If you want to use this script, please see how to install it on this page: User:P.T.Đ/TwinkleMobile. I don't know English, so I can only write basic sentences. Thanks. P.T.Đ (talk) 19:57, 28 November 2021 (UTC)

Thanks for the note @P.T.Đ. This looks excellent. Ideally, we should integrate minerva support into the gadget. I'll open a github issue for that. Sidenote: you should probably use the Toolforge CDN instead of cdnjs for loading an external library to comply with the wikimedia privacy policy. – SD0001 (talk) 15:58, 1 December 2021 (UTC)
Thanks @SD0001. I used Toolforge CDN for external library. I made this because some viwiki users want to use Twinkle on mobile. If Twinkle is updated for using on mobile (and the gadget supports mobile view, loads scripts with ResourceLoader), I will disable this script. P.T.Đ (talk) 22:44, 2 December 2021 (UTC)
Opened #1483 on the issue tracker. – SD0001 (talk) 17:09, 5 December 2021 (UTC)

Can't use Twinkle for edit warring reports

I've tried twice across different days already, but every time I fill out the edit warring report nothing happens when I press accept, the window just stays open as if I never clicked it and no report gets placed. Megaman en m (talk) 06:44, 8 December 2021 (UTC)

@Megaman en m. I was unable to reproduce this on test wiki. Can you give additional information? 1) The exact data you were typing into the form / exactly how you filled out the form. You can screenshot if you want. 2) After Twinkle hangs, open your browser's developer tools window (F12 hotkey on Google Chrome desktop), click on Console, and provide a screenshot. This is where Twinkle error messages are likely to be. Example. Thanks. –Novem Linguae (talk) 07:02, 8 December 2021 (UTC)
Here it is, it also prompts me if I want to send it even though I haven't given a warning to them yet, to which I say yes, then this happens. (There actually is a warning given by someone else, but it doesn't register that.)--Megaman en m (talk) 09:27, 8 December 2021 (UTC)
Did I provide enough information?--Megaman en m (talk) 03:52, 9 December 2021 (UTC)
@Megaman en m. Hey there, thanks for the details. 1) Can you also give the user's name? 2) Can you give the URL of the warning diff? 3) Had you clicked the button yet in the above screenshot? I was expecting to see a Twinkle error but I don't see it, makes me wonder if you had clicked submit yet. Thanks. –Novem Linguae (talk) 05:06, 10 December 2021 (UTC)
Username: Buffalo8
Also I would like to point out that right now I can't even load the intelligence quotient page when trying to report him with Twinkle, even after trying all the spelling and capitalization differences (It just says "none found"). And yes, I did click the submit query button back then, several times across several days, it just hangs there like nothing happened. Pretty sure I pressed it as well when I made that screenshot. So unless there's a hidden loading time that lasts up to a minute, it's just not working for me. I can however use the vandalism report tool on Twinkle without issue.--Megaman en m (talk) 08:11, 10 December 2021 (UTC)
Alright, confirmed, I was able to reproduce it. For some reason, for the combination of AIV->AN3, username Buffalo8, page Intelligence quotient, the API query is not returning any revisions, so the "user's reverts" section in the modal window is empty. @SD0001, at first glance, does anything look wrong with this API query that is used in twinklearv.js -> getAN3Entries() that would cause it not to return any revisions? Direct link: Thanks. –Novem Linguae (talk) 09:41, 10 December 2021 (UTC)
@Novem Linguae looks like rvend is being set incorrectly. – SD0001 (talk) 12:47, 10 December 2021 (UTC)

Megaman en m. Alright, so after more investigating... the reason that the revisions wouldn't show up after a few days is that Twinkle only grabs revisions from within the last 48 hours. This is probably by design, to prevent stale AN3 reports. I hacked in some code to bypass that and then I attempted to warn the subject using the exact same info you filled into the form, and it worked for me. So I'm unable to reproduce. I undid my warnings, but if you want I suppose you could restore them and edit your name in place of mine. I'm out of ideas, sorry we couldn't get you a more satisfactory resolution. –Novem Linguae (talk) 07:27, 11 December 2021 (UTC)

Missing template in warning series

For some reason the {{uw-attempt4im}} template (only warning for deliberately triggering the edit filter) isn't included under the "Only warning" menu under Twinkle's warn module. I've been using the template via a manual edit substitution, but this should be added to the module. Taking Out The Trash (talk) 16:37, 8 December 2021 (UTC)

I patched that one here a week or two ago. It will be fixed in the next release. –Novem Linguae (talk) 17:15, 8 December 2021 (UTC)

Changing TFD behaviour

Per this discussion which has seen no dissent, could we please have Twinkle place new TFD nominations as a new section at the bottom of the appropriate TFD log page? Primefac (talk) 21:27, 11 December 2021 (UTC)

Hey @Primefac. I wrote a patch for this just now. If approved, it will be included in the next Twinkle release. –Novem Linguae (talk) 00:43, 12 December 2021 (UTC)
Thanks! Primefac (talk) 09:13, 12 December 2021 (UTC)

Twinkle's delete function

Hey, I have so many comments about Twinkle which I use throughout the day. But right now, I'd like to ask why, when admins use Twinkle to delete pages, it will delete the article, the article talk page, any redirects to the article, but not the talk page of the redirects to the article.

Luckily, we have bots that pick up mistakes like this and deliver them in reports at some point during the day/night but it would be simpler if Twinkle would just delete the redirect talk pages while it's deleting all of the other related pages. Thanks. Liz Read! Talk! 06:36, 13 December 2021 (UTC)

Hey @Liz. I think there's an open ticket for this one from April. It just needs code. I'll see if I can carve out some time to code it. –Novem Linguae (talk) 06:45, 13 December 2021 (UTC)
Patch submitted for the batchdelete module. [1][2]Novem Linguae (talk) 12:33, 13 December 2021 (UTC)
Yes, I thought I probably had brought it up before. Is it because there isn't a direct link from the redirect talk page to the article that is being deleted like there is from the talk page and the redirect page? Thanks for working on it. Liz Read! Talk! 18:19, 14 December 2021 (UTC)


Twinkle's CSD tagging function on user pages still lists an option for criterion WP:U3, which was deprecated in July 2021. –LaundryPizza03 (d) 21:15, 14 December 2021 (UTC)

@LaundryPizza03. Patch submitted. Thanks for reporting. –Novem Linguae (talk) 02:48, 15 December 2021 (UTC)

2015th nomination

I was a bit bemused when I came across Wikipedia:Articles for deletion/The Basement (2015th nomination). Apparently, Twinkle noticed the AfD at Wikipedia:Articles for deletion/The Basement (2014) (which was about an article at The Basement (2014)) and figured it was the 2014th nomination of The Basement. When The Basement was nominated for deletion yesterday, Twinkle incremented the count by one, and we thus have the 2015th nomination. Not sure what can or should be done about this: I just wanted to point it out in case someone more technically adept than me has any ideas. Extraordinary Writ (talk) 01:25, 17 December 2021 (UTC)

Sounds like a bug. Ill take a stab at writing a patch when I'm at a computer. –Novem Linguae (talk) 02:55, 17 December 2021 (UTC)
Got it. Patch submitted. Please see link above. –Novem Linguae (talk) 15:46, 17 December 2021 (UTC)
Thank you! Extraordinary Writ (talk) 18:28, 17 December 2021 (UTC)

Welcome messages added above "Talk header"

Hi, Liz pointed out on an issue on my talk page that amounts basically to if a talk page has a {{Talk header}} at the top already then the welcome message added by Twinkle (assuming you have "Place welcomes above existing content on user talk pages" set) is added above this. I can see the point that this is maybe not the best logical order, although I'm personally also happy just seeing the welcome and {{Talk header}} as one big header.

The reason this happens a lot is that the AFCH tool, that AfC uses, automatically adds {{Talk header}} to blank talk pages when posting the review notifications (accepts, decline or reject). Then if I, or others, then add a welcome, which I do to both give help and reduce the bite of any decline/reject, it is placed above the "header".

So the question is do others think that if Twinkle is set to "Place welcomes above existing content on user talk pages" is should still place after any existing {{Talk header}} (and possibly other templates), and if yes then would it be possible to change the order? Cheers KylieTastic (talk) 13:41, 18 December 2021 (UTC)

Hey KylieTastic. Patch submitted. Thanks for reporting. –Novem Linguae (talk) 16:42, 18 December 2021 (UTC)
Cheers Novem Linguae KylieTastic (talk) 16:45, 18 December 2021 (UTC)

How to add Turkish Welcome Greeting?

I noticed that the following templates exist but are not in the Twinkle. Additionally I noticed that Oriya (Odia) and Romanian were in Twinkle but not listed in WP:WELCOME-FOREIGN which I've changed just now.

I tried to find appropriate place to change this, but figured asking would be the best. Thanks! ~ 🦝 Shushugah (he/him • talk) 16:06, 20 December 2021 (UTC)

You can add custom welcome templates from WP:TWPREF#welcome "Custom welcome templates to display". – SD0001 (talk) 18:17, 20 December 2021 (UTC)

Release soon?

Hey @SD0001. Happy holidays. The Twinkle gadget is 24 commits behind master. Any interest in doing a release soon? How's that work, do we just need to ping MusikAnimal to run the release script? –Novem Linguae (talk) 14:59, 22 December 2021 (UTC)

@Novem Linguae Yes, let's get 1460 merged first, then you can ping MusikAnimal for running the deploy script after running some sanity tests of the modules or code paths that have been changed, ideally in a different browser than the one you normally use. Almost all changes have been tested by at least two people so hopefully there won't be any bugs. Testing with IE 11 may also be a good idea, not because I think people still use IE, but because if it works in IE it will pretty well work in all other browsers. Happy holidays! – SD0001 (talk) 18:41, 22 December 2021 (UTC)

Redirect format

Hi! A minor issue I noticed: Twinkle tags redirects in the format:

#REDIRECT [[Example]]
{{Redirect category shell|
{{R to example}}

I think there should be another newline (i.e. two in total) after
#REDIRECT [[Example]] i.e.

#REDIRECT [[Example]]

{{Redirect category shell|
{{R to example}}

 ― Qwerfjkltalk 12:39, 24 December 2021 (UTC)

@Qwerfjkl. Patch submitted. Thanks for reporting. Happy holidays. –Novem Linguae (talk) 13:39, 24 December 2021 (UTC)

Add Template:Thanks to IP welcome messages

I don't often use {{Welcome-anon}}, because it seems kinda silly to expect that someone might be interested in delving into all our resources when they haven't yet expressed enough interest to even register an account. I think {{Thanks}} is much better suited for communicating with IPs who make constructive contributions, so I'd like to suggest we add it to the Twinkle IP welcome messages. Thoughts? {{u|Sdkb}}talk 19:43, 29 December 2021 (UTC)

Notified: Wikipedia talk:Welcoming committee. {{u|Sdkb}}talk 19:44, 29 December 2021 (UTC)
Sdkb. Patched submitted, see tracking box for link. Happy holidays. –Novem Linguae (talk) 02:53, 30 December 2021 (UTC)
@Novem Linguae, much thanks, and happy holidays to you, too! Cheers, {{u|Sdkb}}talk 03:01, 30 December 2021 (UTC)

PROD reasons cannot be recovered for reuse if the article has deletion tags on the talk page

If you try to PROD an article, that has deletion tags on the talk page, then not only does the Script stops but it also does not allow the recovery of the PROD reason that was typed. The scripts says "Looking up page creator: Done, found Arslanmulk Checking talk page for prior nominations: Previous XfD template found on talk page, aborting procedure".

The logical next step in such case is XFD, but the reason generally remains the same. The Script should show the user whatever he typed and allow him to reuse the PROD reasoning that was typed before. Venkat TL (talk) 13:47, 1 January 2022 (UTC)

Thanks for the feature request. I've noticed this too and I filed a very similar feature request here in March 2021. Appears to have consensus, just needs code. –Novem Linguae (talk) 19:22, 1 January 2022 (UTC)

Failed to notify user talkpage of CSD

Hello. I speedy nominated User:Queenbesties/sandbox/Queen Besties as CSD G11. While it tagged the userpage properly, Twinkle failed to send a notification to the user about the CSD with Template:Db-spamuser-notice. Twinkle gave me the following error:

  • Failed to save edit:

[4a2c0caa-6364-4aa4-933e-30ff2f4d257d] Caught exception of type Wikimedia\Rdbms\DBQueryError

Because of this, I manually used the CSD warning template on the user's talkpage. I should note the talkpage was originally not created before my CSD notification. This is the first time I ran into this issue of not being able to notify an user on their talkpage with Twinkle for a speedy deletion. Does anyone know why this is the case? Thanks! --MrLinkinPark333 (talk) 21:56, 1 January 2022 (UTC)

That's an error originating from MediaWiki itself which Twinkle can't do anything about. I have been encountering a similar DBQueryError in one of my bot tasks for the past 2 weeks, for which I filed phab:T298010 but unfortunately no one seems interested in looking into it. – SD0001 (talk) 05:54, 2 January 2022 (UTC)